No combat effects. You get some minor rewards for leveling friendship level, and in the future, some fighters can teach Shallot their Special Moves.
When you Max out a Friendship Level, a Prompt Comment will pop up explaining its sole purpose. Which involves teaching Shallot their Special Moves.